[k8s-extension] Update extension CLI to v1.4.3#6575
Closed
bavneetsingh16 wants to merge 85 commits intoAzure:mainfrom
Closed
[k8s-extension] Update extension CLI to v1.4.3#6575bavneetsingh16 wants to merge 85 commits intoAzure:mainfrom
bavneetsingh16 wants to merge 85 commits intoAzure:mainfrom
Conversation
* First draft for Data Protection K8s backup extension (Pending internal review) * Removing tracing * Minor changes to improve azdev style * Internal PR review feedback Co-authored-by: Rishabh Raj <rishraj@microsoft.com>
…ad of workspace (#175) * fix: Update DCR creation to Clusters resource group instead of workspace * . * . * casing check
adding the api version to the operation definition in the client factory
bump k8s-extension version to 1.3.6
…n expected by the service
…tests adding tests for all 4 extension types calls
…tensiontypetests adding upstream test for extension types
…eate (#188) * Add more validations and user prompt for existing installation scenario Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Add Dapr test' Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Handle stateful set Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Update default handling Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Fix HA handling Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Add placement service todo Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Add non-interactive mode Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Fix lint Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Update tests Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Reset configuration for StatefulSet during k8s upgrade Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Fix lint Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Retrigger tests Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Add changes to manage ha and placement params Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * Update message Signed-off-by: Shubham Sharma <shubhash@microsoft.com> * nits Signed-off-by: Shubham Sharma <shubhash@microsoft.com> Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
bump k8s-extension version to 1.4.1
bump k8s-extension version to 1.4.2
…ttings with streams field (#232) * extend containerinsights datacollection settings with streams field * bug fix * fix lint issues * fix pr feedback * fix pr feedback * fix lint error
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
bump k8s-extension version to 1.4.3
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @bavneetsingh16, |
Collaborator
|
k8s-extension |
microsoft-github-policy-service
bot
requested review from
wangzelin007,
yonzhan and
zhoxing-ms
zhoxing-ms
reviewed
Jul 31, 2023
Comment on lines
+207
to
+208
| return VersionInfo.parse(v1) < VersionInfo.parse(v2) | ||
| except ValueError: |
Contributor
There was a problem hiding this comment.
May I ask why do you need to use semver instead of packaging?
Contributor
Author
There was a problem hiding this comment.
The reason is mentioned in AzureArcForKubernetes#241. Please let me know if you need more information.
jiasli
approved these changes
Aug 4, 2023
Member
|
Approving for the usage of BTW, there are 85 commits in this PR. It's better to rebase it to |
3 tasks
Contributor
@bavneetsingh16 Please help rebase the code |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.